Activity
Mon
Wed
Fri
Sun
Sep
Oct
Nov
Dec
Jan
Feb
Mar
Apr
May
Jun
Jul
What is this?
Less
More

Memberships

Selftaught Developer Incubator

377 members • $49/m

Developer Pro

22 members • $250/m

98 contributions to Developer Pro
PR-portfolio
this pr is getting longer so if all good, i better merge and creatw new PR @Cristian Florea please review, thanks. https://github.com/SherpaMilan/cryptoApp/pull/27
3
0
React Challenge 1
Hope its ok as I have done a diferent design on the form. I am having a lot of fun with React so far 🙂 Just feel that maybe i could have done a better job for some reason. Some feedback would be appreciated on what I could improve 🙏 https://codesandbox.io/p/sandbox/signin-signup-form-vng427
React Challenge 1
1 like • Jun 27
looks good
PR-converter page
https://github.com/SherpaMilan/cryptoApp/pull/26 @Cristian Florea here i think i did lots of work. try to make as best as possible. This converter has a way to search coins if it is not in the local list. we can mark favourite , recent coins goes to recent column, it supports default currency change, please have a look, thank you
PR-converter page
0 likes • Jun 13
@Adelin Rosca thank you
0 likes • Jun 16
@Cristian Florea thank you
Console errors
Do we keep them in our projects or not? What's the best practice?
0 likes • Jun 2
from what i know if you want to see the console yes while working, but not when you are deploying. anyway this eslint keeps giving you warnings to remove
1 like • Jun 2
@Monica Ular yes but if you deploy the app and user clicks something and if there is console on the code They can see which is not that professional Just my opinion
PR- search Coins and dark mode
Hi @Cristian Florea , i think i mistakenly created another dark mode branch on top of search branch, i have tried to resolve search coins feedback and please review it altogether. https://github.com/SherpaMilan/cryptoApp/pull/23
1
0
1-10 of 98
Milan Sherpa
5
139 points to level up
@milan-sherpa-3093
Frontend developer 🐦‍🔥

Active 6d ago
Joined Jun 21, 2024
Perth